Add simple test script for testing out widely branched transform hierarchies #11437
+98
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…archies With lots of entities ofc.
Wumpf
added
🔨 testing
|
Web viewer built successfully.
Note: This comment is updated whenever you push a commit. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new comprehensive test script for evaluating performance of widely branched transform hierarchies and removes an older, simpler many entities test. The new test script provides extensive configuration options for testing transform system performance at scale.
- Added
many_entity_transforms/main.pywith configurable hierarchy depth, branching factor, and transform frequency - Removed the basic
many_entities/main.pyscript - Added profiling scope to
resolve_entity_views_and_update_overrideswhile removing profile scope fromvisit_entity_with_overrides
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/python/many_entity_transforms/main.py | New comprehensive transform hierarchy performance test with multiple configuration options |
| tests/python/many_entities/main.py | Removed simple many entities test script |
| crates/viewer/re_viewport_blueprint/src/view_contents.rs | Moved profiling scope from frequently called function to higher-level function |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With lots of entities ofc.
Which also means that it practically replaces
many_entities/main.pyAdded as a super simple eyeballing-based end-to-end perf test that I'm using to make sure we don't regress perf as we're working on extending the transform system.
As we know, many entities is marred by various avoidable perf issues, notably transform perf is bad but not significant right now 😭
Example runs illustrating this: